Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openImpliesClose logic seems to be tripped up by intervening tags #1076

Closed
vassudanagunta opened this issue Jan 13, 2022 · 1 comment
Closed

openImpliesClose logic seems to be tripped up by intervening tags #1076

vassudanagunta opened this issue Jan 13, 2022 · 1 comment
Labels
wontfix Out of scope for the project

Comments

@vassudanagunta
Copy link
Contributor

Given the following input:

<p>one <b>bold <p>two

htmlparser2 generates events equivalent to the following:

<p>one <b>bold <p>two</p></b></p>

Notice how the opening of the second p does not implicitly close the first.

If you remove the intervening <b> tag:

<p>one bold <p>two

then htmlparser2 generates the correct events:

<p>one bold </p><p>two</p>
vassudanagunta added a commit to vassudanagunta/htmlparser2 that referenced this issue Jan 13, 2022
@vassudanagunta
chore(tests): Add test cases for misnested tags
aaf85c2 
47-misnested-formatting-tags.json demonstrates and covers Issue fb55#1075.

48-misnested-formatting-and-block-tags.json demonstrates and covers both
Issue fb55#1075 and Issue fb55#1076, and their possible interaction.
@vassudanagunta vassudanagunta mentioned this issue Jan 13, 2022
Closed
@vassudanagunta vassudanagunta mentioned this issue Apr 3, 2022
Merged
@fb55 fb55 added the wontfix Out of scope for the project label Apr 23, 2022
@fb55
Copy link
Owner

fb55 commented Apr 23, 2022

"Fixed" by #1147

@fb55 fb55 closed this as completed Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
wontfix Out of scope for the project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fb55 @vassudanagunta