Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(readme): Add message in README steering people to parse5 if they need HTML5 compliance #1147

Merged
merged 3 commits into from Apr 23, 2022

Conversation

vassudanagunta
Copy link
Contributor

I think this is important to steer people to htmlparser2 or parse5 based on this key difference, especially since this difference is fundamental and permanent. It's important to do this up front to save people the time and effort of finding out the hard way.

Fixes #1075

Happy to reword or make any other changes you want, or drop this and leave it all to you :)

@coveralls
Copy link

coveralls commented Apr 3, 2022

Pull Request Test Coverage Report for Build 2212190919

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 10 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.5%) to 99.426%

Files with Coverage Reduction New Missed Lines %
src/fixtures/test-helper.ts 3 97.45%
src/Tokenizer.ts 7 99.14%
Totals Coverage Status
Change from base Build 2082618917: 0.5%
Covered Lines: 1907
Relevant Lines: 1918

💛 - Coveralls

@vassudanagunta
Copy link
Contributor Author

@fb55 This may also "fix" #1076 ?

The lint check failures pre-existing, unrelated to this PR.

@fb55 fb55 enabled auto-merge (squash) April 23, 2022 11:38
@fb55 fb55 merged commit 040564e into fb55:master Apr 23, 2022
@vassudanagunta vassudanagunta deleted the readme-parse5 branch April 24, 2022 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handling of "misnested" formatting tags does not match standard HTML behavior
3 participants