Skip to content

Commit

Permalink
test: upgrade Playwright
Browse files Browse the repository at this point in the history
  • Loading branch information
fbasso committed Sep 14, 2023
1 parent 55f45fd commit cdac2af
Show file tree
Hide file tree
Showing 4 changed files with 25 additions and 19 deletions.
12 changes: 6 additions & 6 deletions e2e-app/src/app/timepicker/filter/timepicker-filter.e2e-spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@ test.describe('Timepicker Filter', () => {
test(`should accept numbers`, async () => {
await expectValue('::'); // No starting values

await getPage().type(SELECTOR_HOUR, '1');
await getPage().type(SELECTOR_MIN, '2');
await getPage().type(SELECTOR_SEC, '3');
await getPage().locator(SELECTOR_HOUR).pressSequentially('1');
await getPage().locator(SELECTOR_MIN).pressSequentially('2');
await getPage().locator(SELECTOR_SEC).pressSequentially('3');

await getPage().click(SELECTOR_HOUR);
await expectValue('01:02:03');
Expand All @@ -29,9 +29,9 @@ test.describe('Timepicker Filter', () => {
test(`shouldn't accept alpha`, async () => {
await expectValue('::'); // No starting values

await getPage().type(SELECTOR_HOUR, 'A');
await getPage().type(SELECTOR_MIN, 'A');
await getPage().type(SELECTOR_SEC, 'A');
await getPage().locator(SELECTOR_HOUR).pressSequentially('A');
await getPage().locator(SELECTOR_MIN).pressSequentially('A');
await getPage().locator(SELECTOR_SEC).pressSequentially('A');

await getPage().click(SELECTOR_HOUR);
await expectValue('::');
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ const expectTypeaheadToBeClosed = async (message: string) => {
};

const setTypeaheadValue = async (text: string) => {
await getPage().type(SELECTOR_TYPEAHEAD, text);
await getPage().locator(SELECTOR_TYPEAHEAD).pressSequentially(text);
await expectTypeaheadToBeOpen(`Typed ${text}, should be open`);
};

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ test.describe('Typeahead', () => {

test(`should preserve value previously selected with mouse when reopening with focus then closing without selection`, async () => {
await getPage().click(SELECTOR_TYPEAHEAD);
await getPage().type(SELECTOR_TYPEAHEAD, 'col');
await getPage().locator(SELECTOR_TYPEAHEAD).pressSequentially('col');

await waitForDropdownOpen(2);
await waitForTypeaheadFocused();
Expand Down
28 changes: 17 additions & 11 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2034,14 +2034,11 @@
integrity sha512-+1VkjdD0QBLPodGrJUeqarH8VAIvQODIbwh9XpP5Syisf7YoQgsJKPNFoqqLQlu+VQ/tVSshMR6loPMn8U+dPg==

"@playwright/test@^1.32.1":
version "1.33.0"
resolved "https://registry.yarnpkg.com/@playwright/test/-/test-1.33.0.tgz#669ef859efb81b143dfc624eef99d1dd92a81b67"
integrity sha512-YunBa2mE7Hq4CfPkGzQRK916a4tuZoVx/EpLjeWlTVOnD4S2+fdaQZE0LJkbfhN5FTSKNLdcl7MoT5XB37bTkg==
version "1.38.0"
resolved "https://registry.yarnpkg.com/@playwright/test/-/test-1.38.0.tgz#0ad33f62394d6a9cb768d0ddfa93b12304c64e13"
integrity sha512-xis/RXXsLxwThKnlIXouxmIvvT3zvQj1JE39GsNieMUrMpb3/GySHDh2j8itCG22qKVD4MYLBp7xB73cUW/UUw==
dependencies:
"@types/node" "*"
playwright-core "1.33.0"
optionalDependencies:
fsevents "2.3.2"
playwright "1.38.0"

"@popperjs/core@2.11.6":
version "2.11.6"
Expand Down Expand Up @@ -9265,10 +9262,19 @@ pkg-dir@^4.1.0, pkg-dir@^4.2.0:
dependencies:
find-up "^4.0.0"

playwright-core@1.33.0:
version "1.33.0"
resolved "https://registry.yarnpkg.com/playwright-core/-/playwright-core-1.33.0.tgz#269efe29a927cd6d144d05f3c2d2f72bd72447a1"
integrity sha512-aizyPE1Cj62vAECdph1iaMILpT0WUDCq3E6rW6I+dleSbBoGbktvJtzS6VHkZ4DKNEOG9qJpiom/ZxO+S15LAw==
playwright-core@1.38.0:
version "1.38.0"
resolved "https://registry.yarnpkg.com/playwright-core/-/playwright-core-1.38.0.tgz#cb8e135da1c0b1918b070642372040ed9aa7009a"
integrity sha512-f8z1y8J9zvmHoEhKgspmCvOExF2XdcxMW8jNRuX4vkQFrzV4MlZ55iwb5QeyiFQgOFCUolXiRHgpjSEnqvO48g==

playwright@1.38.0:
version "1.38.0"
resolved "https://registry.yarnpkg.com/playwright/-/playwright-1.38.0.tgz#0ee19d38512b7b1f961c0eb44008a6fed373d206"
integrity sha512-fJGw+HO0YY+fU/F1N57DMO+TmXHTrmr905J05zwAQE9xkuwP/QLDk63rVhmyxh03dYnEhnRbsdbH9B0UVVRB3A==
dependencies:
playwright-core "1.38.0"
optionalDependencies:
fsevents "2.3.2"

portscanner@2.2.0:
version "2.2.0"
Expand Down

0 comments on commit cdac2af

Please sign in to comment.