#59 get no_proxy in from reqwest #122
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
no_proxy support is often a requirement in corporate use cases. |
|
It is good to have dependencies up to date but I don't understand this change. https://docs.rs/reqwest/0.10.4/reqwest/struct.ClientBuilder.html#method.no_proxy Why this change? |
|
I tested it with Reqwest 0.10.4 with no success. Then I patched drill to use Reqwest 0.10.10, and it worked as expected. See also |
|
If you opt in for upgrading reqwest 0.10.10, the NO_PROXY issue is solved and a NO_PROXY setting in the env is supported. |
|
Why this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reqwest 0.10.10 has system proxy / no_proxy support included.