Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(checkContext): type as array #636

Merged
merged 4 commits into from Jul 30, 2021
Merged

fix(checkContext): type as array #636

merged 4 commits into from Jul 30, 2021

Conversation

fratzinger
Copy link
Collaborator

Problem:

checkContext was not able to handle type as array, although it was defined in index.d.ts.

Solution:

transform type into array (same as method) and check against type with Array.prototype.includes().
Also added tests for this scenario.

No breaking change. No new feature. The typings already seem like this would work.

@daffl daffl merged commit 9cdf642 into feathersjs-ecosystem:master Jul 30, 2021
@fratzinger fratzinger deleted the patch-1 branch July 31, 2021 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants