Dove Support #125
Open
Dove Support #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests failing
Bumped typescript to 4.5.5 Tests failing
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updated to work with
^5.0.0-pre.16No
No
Other Information
This pull request updates the dependencies to
^5.0.0-pre.16. No changes were needed to the actual lib files. All tests now pass withnpm test. If it would be better to do this as a full Typescript implementation, I can work on that.Since the
FeathersErrorpropertiesdataanderrorsare now optional and not used in the test, I removed them from expected result in the tests. I guess another option would be to use aForbiddenerror with the expected message? I can make that change if needed.It would obviously be better for this to remain it's own branch and did not merge with
releaseormaster, but there is not currently a Dove branch.