This repository has been archived by the owner on Sep 27, 2020. It is now read-only.
Fixed transformAST.TypeName #99
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In transformAST.TypeName, it is possible for ctx.children to be null. An example scenario is when the last argument of a function definition has a trailing comma. The existing implementation assumes ctx.children has the property 'length', which causes an exception when ctx.children is null. This commit fixes this issue by adding an if statement.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
transformAST.TypeName, it is possible forctx.childrento benull. An example scenario is when the last argument of a function definition has a trailing comma.The existing implementation assumes
ctx.childrenhas the propertylength, which causes an exception whenctx.childrenisnull. This commit fixes this issue by adding an if statement that checks for this condition. Ifctx.childrenis indeednull, the fixed version returnsthis.visit(ctx.getChild(0)), which is the default return value used in the existing implementation.