Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Shouldn't onChange, onError and addError be protected ? #3068

Closed
cedvdb opened this issue Dec 16, 2021 · 1 comment · Fixed by #3071
Closed

refactor: Shouldn't onChange, onError and addError be protected ? #3068

cedvdb opened this issue Dec 16, 2021 · 1 comment · Fixed by #3071
Assignees
@felangel
Labels
bug Something isn't working pkg:bloc This issue is related to the bloc package
Projects
bloc

Comments

@cedvdb
Copy link

cedvdb commented Dec 16, 2021 •
edited

This is bothering me a bit, shouldn't onChange, onError and addError be protected ? it looks odd as a public api.
@cedvdb cedvdb added the refactor Refactor an existing implementation label Dec 16, 2021
@felangel felangel mentioned this issue Dec 16, 2021
Merged
7 tasks
@felangel felangel self-assigned this Dec 16, 2021
@felangel felangel added bug Something isn't working pkg:bloc This issue is related to the bloc package and removed refactor Refactor an existing implementation labels Dec 16, 2021
@felangel felangel added this to To do in bloc via automation Dec 16, 2021
@felangel felangel moved this from To do to In progress in bloc Dec 16, 2021
@felangel
Copy link
Owner

Hi @cedvdb 👋
Thanks for opening an issue!

Good catch, I agree they should be protected 👍

I opened #3071 to make onChange and addError protected (onError is already protected).

bloc automation moved this from In progress to Done Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@felangel felangel

Labels
bug Something isn't working pkg:bloc This issue is related to the bloc package
Projects
bloc
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(bloc): make onChange and addError protected felangel/bloc
2 participants
@felangel @cedvdb