Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bloc): make onChange and addError protected #3071

Merged
merged 2 commits into from Dec 16, 2021

Conversation

felangel
Copy link
Owner

@felangel felangel commented Dec 16, 2021

Status

READY

Breaking Changes

NO

Description

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@felangel felangel added bug Something isn't working pkg:bloc This issue is related to the bloc package labels Dec 16, 2021
@felangel felangel self-assigned this Dec 16, 2021
@felangel felangel added this to In progress in bloc via automation Dec 16, 2021
@codecov
Copy link

codecov bot commented Dec 16, 2021

Codecov Report

Merging #3071 (cc368e7) into master (9a6c82e) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master     #3071    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           17         8     -9     
  Lines          367       191   -176     
==========================================
- Hits           367       191   -176     
Impacted Files Coverage Δ
packages/bloc/lib/src/bloc_base.dart 100.00% <100.00%> (ø)
...ages/flutter_bloc/lib/src/multi_bloc_provider.dart
packages/flutter_bloc/lib/src/bloc_consumer.dart
...lutter_bloc/lib/src/multi_repository_provider.dart
packages/flutter_bloc/lib/src/bloc_builder.dart
packages/flutter_bloc/lib/src/bloc_selector.dart
packages/flutter_bloc/lib/src/bloc_provider.dart
packages/flutter_bloc/lib/src/bloc_listener.dart
...ages/flutter_bloc/lib/src/repository_provider.dart
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 399eaee...cc368e7. Read the comment docs.

@felangel felangel merged commit c47d11e into master Dec 16, 2021
bloc automation moved this from In progress to Done Dec 16, 2021
@felangel felangel deleted the fix/protected-onChange-onError branch December 16, 2021 05:14
@felangel felangel mentioned this pull request Dec 29, 2021
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pkg:bloc This issue is related to the bloc package
Projects
bloc
  
Done
Development

Successfully merging this pull request may close these issues.

refactor: Shouldn't onChange, onError and addError be protected ?
1 participant