Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(bloc): internal reorganization #3011

Merged
merged 1 commit into from Nov 28, 2021

Conversation

felangel
Copy link
Owner

Status

READY

Breaking Changes

NO

Description

  • refactor(bloc): internal reorganization

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@felangel felangel added pkg:bloc This issue is related to the bloc package refactor Refactor an existing implementation labels Nov 28, 2021
@felangel felangel self-assigned this Nov 28, 2021
@felangel felangel added this to In progress in bloc via automation Nov 28, 2021
@codecov
Copy link

codecov bot commented Nov 28, 2021

Codecov Report

Merging #3011 (ab38140) into master (e94b68c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #3011   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         7    +4     
  Lines          178       184    +6     
=========================================
+ Hits           178       184    +6     
Impacted Files Coverage Δ
packages/bloc/lib/src/bloc.dart 100.00% <ø> (ø)
packages/bloc/lib/src/bloc_observer.dart 100.00% <ø> (ø)
packages/bloc/lib/src/transition.dart 100.00% <ø> (ø)
packages/bloc/lib/src/bloc_base.dart 100.00% <100.00%> (ø)
packages/bloc/lib/src/bloc_overrides.dart 100.00% <100.00%> (ø)
packages/bloc/lib/src/cubit.dart 100.00% <100.00%> (ø)
packages/bloc/lib/src/emitter.dart 100.00% <100.00%> (ø)
...ackages/hydrated_bloc/lib/src/hydrated_cipher.dart
packages/hydrated_bloc/lib/src/hydrated_bloc.dart
...ckages/hydrated_bloc/lib/src/hydrated_storage.dart
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 370d6ea...ab38140. Read the comment docs.

@felangel felangel merged commit e4839da into master Nov 28, 2021
@felangel felangel deleted the refactor/bloc-internal-reorganization branch November 28, 2021 03:15
bloc automation moved this from In progress to Done Nov 28, 2021
@felangel felangel mentioned this pull request Dec 29, 2021
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:bloc This issue is related to the bloc package refactor Refactor an existing implementation
Projects
bloc
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant