refactor(bloc): add isClosed to Closable interface

[purplenoodlesoop]

Closes #3065

Status

READY

Breaking Changes

NO

Description

There are three main changes done in the following PR. All of them are targeted to extend the recent "core interfaces" update to further apply the Interfaces Segregation and Dependency Inversion principles.

Refer to #3065

Type of Change

• ✨ New feature (non-breaking change which adds functionality)
• 🛠️ Bug fix (non-breaking change which fixes an issue)
• ❌ Breaking change (fix or feature that would cause existing functionality to change)
• 🧹 Code refactor
• ✅ Build configuration change
• 📝 Documentation
• 🗑️ Chore

[felangel]

What's the benefit of introducing this interface? I don't like the name hooks because it can be confused with flutter_hooks and I also would prefer not to define interfaces unnecessarily. Is there a concrete use-case you had in mind which required operating on this interface specifically?

[purplenoodlesoop]

What's the benefit of introducing this interface?

The main benefits align with those that ISP and DIP brings — other object can implement the lifecycle calls more easily, other object interested only in lifecycle calls can depend only on desired parts, making code more loosely coupled.

I don't like the name hooks because it can be confused with flutter_hooks and I also would prefer not to define interfaces unnecessarily.

Totally agree, the name can be confusing. LifecycleObserver sounds good!

Is there a concrete use-case you had in mind which required operating on this interface specifically?

Yes, I was implementing a custom, project-specific version of Bloc that needed some of the "on.." methods, and had to either just hard-code them in the implementation, or extend/implement the BlocBase, but not all methods was desired.

Those interfaces would allow to unify lifecycle calls.

On the other hand, I agree that non-essential interfaces can be redundant and open to discard them if you think that it's too much :)

Also, what constitutes a hook? I would expect onCreate, onClose, etc. to also be included.

I agree, they should be also included if we decide to keep the interfaces!

[codecov]

Codecov Report

Merging #3066 (1946930) into master (77bb1ce) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##            master     #3066    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           30         8    -22     
  Lines          721       192   -529     
==========================================
- Hits           721       192   -529     

Impacted Files	Coverage Δ
packages/bloc/lib/src/bloc_base.dart	100.00% <100.00%> (ø)
packages/bloc_concurrency/lib/src/restartable.dart
...ackages/hydrated_bloc/lib/src/hydrated_cipher.dart
...lutter_bloc/lib/src/multi_repository_provider.dart
packages/hydrated_bloc/lib/src/hydrated_bloc.dart
packages/bloc_concurrency/lib/src/sequential.dart
packages/flutter_bloc/lib/src/bloc_selector.dart
packages/flutter_bloc/lib/src/bloc_listener.dart
packages/bloc_concurrency/lib/src/droppable.dart
packages/replay_bloc/lib/src/change_stack.dart
... and 13 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77bb1ce...1946930. Read the comment docs.