Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(bloc): use late keyword for internal state controller #3100

Merged
merged 1 commit into from Dec 29, 2021

Conversation

felangel
Copy link
Owner

Status

READY

Breaking Changes

NO

Description

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@felangel felangel added pkg:bloc This issue is related to the bloc package refactor Refactor an existing implementation labels Dec 29, 2021
@felangel felangel self-assigned this Dec 29, 2021
@felangel felangel added this to In progress in bloc via automation Dec 29, 2021
@codecov
Copy link

codecov bot commented Dec 29, 2021

Codecov Report

Merging #3100 (ec7d557) into master (77ebe56) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master     #3100    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           30         8    -22     
  Lines          722       191   -531     
==========================================
- Hits           722       191   -531     
Impacted Files Coverage Δ
packages/bloc/lib/src/bloc_base.dart 100.00% <100.00%> (ø)
packages/bloc_concurrency/lib/src/droppable.dart
packages/replay_bloc/lib/src/replay_bloc.dart
packages/flutter_bloc/lib/src/bloc_builder.dart
...ages/flutter_bloc/lib/src/repository_provider.dart
packages/bloc_test/lib/src/mock_bloc.dart
packages/replay_bloc/lib/src/change_stack.dart
...ckages/hydrated_bloc/lib/src/hydrated_storage.dart
packages/bloc_concurrency/lib/src/sequential.dart
packages/flutter_bloc/lib/src/bloc_consumer.dart
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8bbb98...ec7d557. Read the comment docs.

@felangel felangel merged commit 91e4c92 into master Dec 29, 2021
bloc automation moved this from In progress to Done Dec 29, 2021
@felangel felangel deleted the refactor/bloc-late-state-controller branch December 29, 2021 21:42
@felangel felangel mentioned this pull request Dec 29, 2021
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:bloc This issue is related to the bloc package refactor Refactor an existing implementation
Projects
bloc
  
Done
Development

Successfully merging this pull request may close these issues.

style(bloc): misc style changes
1 participant