Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix graphite client reconnections on Node 16 and above #17

Merged
merged 3 commits into from Jul 13, 2022

Conversation

jonathansamines
Copy link
Contributor

@jonathansamines jonathansamines commented Jul 8, 2022

Fix graphite client reconnections by bundling lazy-socket into this module. Work was divided into multiple commits:

Fixes #16

@Serphentas
Copy link
Collaborator

LGTM. I think we should release this as a new patch version (i.e. 0.1.5) since there are no major changes (API is untouched).

@Serphentas Serphentas merged commit f513603 into felixge:master Jul 13, 2022
@Serphentas
Copy link
Collaborator

@jonathansamines
Copy link
Contributor Author

Hey @Serphentas thanks for reviewing these changes. Have they already been published to npm?

@Serphentas
Copy link
Collaborator

Serphentas commented Jul 13, 2022

I'm having trouble logging into my npm account, I will let you know when it's published ASAP.

@Serphentas
Copy link
Collaborator

Here it is https://www.npmjs.com/package/graphite/v/0.1.5 thanks for your contribution !

@jonathansamines
Copy link
Contributor Author

Awesome, thank you @Serphentas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Graphite client unable to reconnect after server connection is closed
2 participants