Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pass the future imageData object to the view callback #586 #587

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

M393
Copy link

@M393 M393 commented Feb 7, 2023

This allows setting an initial rotation before an image is displayed.
Resolves #586

new Viewer(dummyDiv, {
  // ...
  view: function (event) {
    event.detail.imageData.rotate = 90;
  },

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of the default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome 108
  • Firefox 110
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

to allow setting rotation before it is displayed.
@fengyuanchen
Copy link
Owner

In order to keep this library simple, I think it is unnecessary to add this feature.

@M393 M393 changed the title feat: pass the future imageData object to the viewed callback #586 feat: pass the future imageData object to the view callback #586 Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow initial image rotation
2 participants