Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some events(full,exit,render) #604

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

tanlng
Copy link

@tanlng tanlng commented Jun 28, 2023

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of the default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@fengyuanchen
Copy link
Owner

Why not use the existing viewed event instead of the adding rendered event?

@tanlng
Copy link
Author

tanlng commented Jul 3, 2023

Why not use the existing viewed event instead of the adding rendered event?
image

I need to synchronously modify the position of the markers after rendering

@fengyuanchen
Copy link
Owner

The moved, rotated, scaled, and zoomed events would also work in your case.

@tanlng
Copy link
Author

tanlng commented Jul 10, 2023

I also need to trigger an event after resizing. If there is a render event, I will not need to update my code after updating new features

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants