fix(ssr): normalize manifest filenames

fixes vitejs#3303
ferdinando-ferreira · May 9, 2021 · e96ad05 · e96ad05
1 parent d555dd6
commit e96ad05
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 3 deletions.
diff --git a/packages/plugin-vue-jsx/index.js b/packages/plugin-vue-jsx/index.js
@@ -4,6 +4,8 @@ const jsx = require('@vue/babel-plugin-jsx')
 const importMeta = require('@babel/plugin-syntax-import-meta')
 const { createFilter } = require('@rollup/pluginutils')
 const hash = require('hash-sum')
+const path = require('path')
+const { createHash } = require('crypto')
 
 const ssrRegisterHelperId = '/__vue-jsx-ssr-register-helper'
 const ssrRegisterHelperCode =
@@ -39,6 +41,7 @@ function ssrRegisterHelper(comp, filename) {
  * @returns {import('vite').Plugin}
  */
 function vueJsxPlugin(options = {}) {
+  let root = ''
   let needHmr = false
   let needSourceMap = true
 
@@ -63,6 +66,7 @@ function vueJsxPlugin(options = {}) {
     configResolved(config) {
       needHmr = config.command === 'serve' && !config.isProduction
       needSourceMap = config.command === 'serve' || !!config.build.sourcemap
+      root = config.root
     },
 
     resolveId(id) {
@@ -217,9 +221,13 @@ function vueJsxPlugin(options = {}) {
           }
 
           if (ssr) {
+            const normalizedId = path.relative(root, id)
+            const hashedId = createHash('sha256')
+              .update(normalizedId)
+              .digest('hex')
             let ssrInjectCode =
               `\nimport { ssrRegisterHelper } from "${ssrRegisterHelperId}"` +
-              `\nconst __moduleId = ${JSON.stringify(id)}`
+              `\nconst __moduleId = ${JSON.stringify(hashedId)}`
             for (const { local } of hotComponents) {
               ssrInjectCode += `\nssrRegisterHelper(${local}, __moduleId)`
             }

diff --git a/packages/plugin-vue/src/main.ts b/packages/plugin-vue/src/main.ts
@@ -1,5 +1,6 @@
 import qs from 'querystring'
 import path from 'path'
+import { createHash } from 'crypto'
 import { rewriteDefault, SFCBlock, SFCDescriptor } from '@vue/compiler-sfc'
 import { ResolvedOptions } from '.'
 import {
@@ -143,13 +144,17 @@ export async function transformMain(
 
   // SSR module registration by wrapping user setup
   if (ssr) {
+    const normalizedFilename = path.relative(options.root, filename)
+    const hashedFilename = createHash('sha256')
+      .update(normalizedFilename)
+      .digest('hex')
     output.push(
       `import { useSSRContext as __vite_useSSRContext } from 'vue'`,
       `const _sfc_setup = _sfc_main.setup`,
       `_sfc_main.setup = (props, ctx) => {`,
       `  const ssrContext = __vite_useSSRContext()`,
       `  ;(ssrContext.modules || (ssrContext.modules = new Set())).add(${JSON.stringify(
-        filename
+        hashedFilename
       )})`,
       `  return _sfc_setup ? _sfc_setup(props, ctx) : undefined`,
       `}`

diff --git a/packages/vite/src/node/ssr/ssrManifestPlugin.ts b/packages/vite/src/node/ssr/ssrManifestPlugin.ts
@@ -1,3 +1,5 @@
+import { relative } from 'path'
+import { createHash } from 'crypto'
 import { ResolvedConfig } from '..'
 import { Plugin } from '../plugin'
 import { chunkToEmittedCssFileMap } from '../plugins/css'
@@ -18,7 +20,12 @@ export function ssrManifestPlugin(config: ResolvedConfig): Plugin {
           // TODO: also include non-CSS assets
           const cssFiles = chunkToEmittedCssFileMap.get(chunk)
           for (const id in chunk.modules) {
-            const mappedChunks = ssrManifest[id] || (ssrManifest[id] = [])
+            const normalizedId = relative(config.root, id)
+            const hashedId = createHash('sha256')
+              .update(normalizedId)
+              .digest('hex')
+            const mappedChunks =
+              ssrManifest[hashedId] || (ssrManifest[hashedId] = [])
             mappedChunks.push(base + chunk.fileName)
             if (cssFiles) {
               cssFiles.forEach((file) => {