Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react-router-dom, react-tooltip & react-transition-group latest version #1199

Merged
merged 3 commits into from May 29, 2023

Conversation

muhamedsalih-tw
Copy link
Contributor

@muhamedsalih-tw muhamedsalih-tw commented May 27, 2023

Pre-flight Checklist

Please ensure you've completed all of the following.

Description of Change

Update react-router-dom, react-tooltip & react-transition-group latest version

Motivation and Context

update package to latest version

Checklist

  • My pull request is properly named
  • The changes respect the code style of the project (pnpm prepare-code)
  • pnpm test passes
  • I tested/previewed my changes locally

Release Notes

@muhamedsalih-tw muhamedsalih-tw marked this pull request as ready for review May 28, 2023 01:30
@muhamedsalih-tw muhamedsalih-tw requested a review from a team as a code owner May 28, 2023 01:30
@vraravam vraravam force-pushed the upgrade-to-react-18 branch 2 times, most recently from 7553951 to e37389a Compare May 28, 2023 08:19
@vraravam vraravam requested review from Alphrag and vraravam May 28, 2023 08:59
@vraravam vraravam merged commit 05ddc54 into ferdium:develop May 29, 2023
4 checks passed
Alphrag pushed a commit to Alphrag/ferdium-app that referenced this pull request May 30, 2023
Alphrag added a commit that referenced this pull request May 30, 2023
@Alphrag
Copy link
Member

Alphrag commented May 30, 2023

I have reverted this because it still seems to cause some trouble on Windows. Interestingly enough, it seems that after a few launches it stabilises and runs completely fine, but initially the app is locked on the purple screen "Something went wrong". I am attaching a file that contains a log of errors that appeared when this happened the first two times (either after updating through the app, or by using the portable version). It would be good if we could figure out exactly where this problem came from so that no user will be affected when we publish the stable.

error-react.console.log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants