Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update react-router-dom,react-tooltip& react-transition-group #1260

Merged
merged 2 commits into from Jul 20, 2023

Conversation

muhamedsalih-tw
Copy link
Contributor

Pre-flight Checklist

Please ensure you've completed all of the following.

Description of Change

Update react-router-dom, react-tooltip & react-transition-group latest version

Motivation and Context

update package to latest version

Checklist

  • My pull request is properly named
  • The changes respect the code style of the project (pnpm prepare-code)
  • pnpm test passes
  • I tested/previewed my changes locally

Release Notes

@muhamedsalih-tw muhamedsalih-tw marked this pull request as ready for review July 4, 2023 01:36
@muhamedsalih-tw muhamedsalih-tw requested a review from a team as a code owner July 4, 2023 01:36
Copy link
Contributor

@vraravam vraravam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine on m1 mac. (Haven't tried teams meeting and screen sharing in any of the configured apps). LGTM

@vraravam
Copy link
Contributor

@Alphrag - have you been able to test this on windows? Could anyone else also do the same please? Its been sitting for quite some time now

@vraravam vraravam merged commit 0a4a049 into ferdium:develop Jul 20, 2023
1 check passed
@vraravam
Copy link
Contributor

I accidentally merged this into the develop branch. (Was trying to rebase from develop for latest changes - so that testing can be done with the latest).
@Alphrag / @SpecialAro - please can one of you confirm if this works on windows today? Else, we will have to revert this commit

@SpecialAro
Copy link
Member

Hey @vraravam 😄

I tested on my windows today and it was working properly!

@Alphrag
Copy link
Member

Alphrag commented Jul 20, 2023

@vraravam Nope, there is still the same error that happens when the update bar should appear, as can be seen below...
The only way to test this problem is to actually build and install the app but setting the version in package.json lower than the latest available release, so that it actually tries to upgrade (in debug mode update is disabled so this behavior can't be seen). I haven't checked if on mac, that also produces the same thing, but I've attached the lof of the errors that appear in the console when this happens.

ws_error_mobxreact

error-module-react.txt

@muhamedsalih-tw
Copy link
Contributor Author

@Alphrag That's helpful, Will resolve it :)

@muhamedsalih-tw
Copy link
Contributor Author

@Alphrag , I tried to replicate failure in mac m1 but it didn't work.
steps:

  1. reduce package.json > version by 1 minor
  2. build the app and install in mac
  3. it having some error when i try to check for update from settings

can you help me with this ? or this issue only occure in windows?

@Alphrag
Copy link
Member

Alphrag commented Jul 23, 2023

can you help me with this ? or this issue only occure in windows?

Answering simply for completeness here: the issue also occurred on Mac, and I was able to reproduce it. However, to make the update banner appear, the app must be built without the --dir option currently present in the build-unix.sh script usually used (with the option the app does not include the file allowing to check for updates). Then having Enable updates toggle will allow the banner to appear if a service is outdated by prompting the reload.
But this is still not enough for the app update banner. Indeed, it only appears when an update is available, has been downloaded and verified for compatibility. Thus, the app must have been signed during the build with the same key as the one from the incoming update, which reduces even more the testing possibilities for this particular event since one needs to have the code signing certificate installed on their computer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants