Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update react-router-dom,react-tooltip& react-transition-group #1278

Merged
merged 2 commits into from Jul 23, 2023

Conversation

muhamedsalih-tw
Copy link
Contributor

Pre-flight Checklist

Please ensure you've completed all of the following.

Description of Change

Update react-router-dom, react-tooltip & react-transition-group latest version

Motivation and Context

update package to latest version

Checklist

  • My pull request is properly named
  • The changes respect the code style of the project (pnpm prepare-code)
  • pnpm test passes
  • I tested/previewed my changes locally

Release Notes

@muhamedsalih-tw muhamedsalih-tw self-assigned this Jul 22, 2023
@muhamedsalih-tw muhamedsalih-tw marked this pull request as ready for review July 22, 2023 18:08
@muhamedsalih-tw muhamedsalih-tw requested a review from a team as a code owner July 22, 2023 18:08
@muhamedsalih-tw
Copy link
Contributor Author

@Alphrag - Have fixed the update issue. Kindly verify in windows build, if all issue are resolved.
@vraravam - kindly verify once (I have also verified it already)

This time let us merge this pr after testing a while in windows

@Alphrag
Copy link
Member

Alphrag commented Jul 23, 2023

That's great thank you 😃 I can confirm that the last changes you've added have indeed fixed the problem both for the recipe reload and the software update banner. So all good on windows this time!
I have also tested it on my mac x64 and everything is working as expected there as well.

Copy link
Contributor

@vraravam vraravam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the normal working of Ferdium on a mac m1 machine. Haven't tested recipe or app upgrades.

@muhamedsalih-tw
Copy link
Contributor Author

Added windows test image(credits: @Alphrag )
Capture-2023-07-23-114729

Added Mac M1 test image
Capture-2023-07-23-114730

Team, if any one tested app in other OS kindly attach your screenshots.

@Alphrag
Copy link
Member

Alphrag commented Jul 23, 2023

Tested also on the appImage on Linux. So we are good to go!

image

@muhamedsalih-tw muhamedsalih-tw merged commit 8708f1d into ferdium:develop Jul 23, 2023
4 checks passed
@muhamedsalih-tw muhamedsalih-tw deleted the update-react-deps branch July 29, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants