Update dependencies #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests are passing locally. Maybe opentok credentials used by the CI expired somehow? |
philn
commented
Jan 17, 2022
The Clap YAML API was deprecated, see: clap-rs/clap#3087 We should move to the Parser API instead, even though YAML was nice... to be done later on. Also pin to latest GStreamer stable releases. Using git snapshots shouldn't be needed, unless we need un-released fixes.
|
This is ready for a review @ferjm please 🙏🏻 |
|
I'll look into the CI issues when I have a moment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Clap YAML API was deprecated, see:
clap-rs/clap#3087
We should move to the Parser API instead, even though YAML was nice... to be
done later on.
Also pin to latest GStreamer stable releases. Using git snapshots shouldn't be
needed, unless we need un-released fixes.