Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove failing and redundant Standard workflow #342

Closed
wants to merge 1 commit into from
Closed

Remove failing and redundant Standard workflow #342

wants to merge 1 commit into from

Conversation

LinusU
Copy link
Contributor

@LinusU LinusU commented Jan 23, 2024

There is no script called standard so npm run standard was always failing.

Also, standard is already run as part of npm test, so it's covered by the other workflow.

This was referenced Jan 23, 2024
Merged
Merged
@dcousens
Copy link
Collaborator

dcousens commented Jan 23, 2024 •
edited

Thanks @LinusU , but I think we should merge #332 first (see that pull request for reasoning)

@dcousens dcousens closed this Jan 23, 2024
@dcousens dcousens reopened this Jan 23, 2024
@dcousens dcousens closed this Jan 23, 2024
@dcousens
Copy link
Collaborator

dcousens commented Jan 23, 2024 •
edited

Added 3404b7e to resolve the missing standard target, thanks @LinusU

@LinusU LinusU deleted the lu-3 branch January 23, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcousens dcousens dcousens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LinusU @dcousens