Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated pull from rust-lang/libc #52

Merged
merged 17 commits into from Oct 17, 2023

Conversation

cd-work and others added 17 commits October 9, 2023 17:42
This constant is a possible bitflag argument for `unshare`:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/include/uapi/linux/sched.h?h=v6.6-rc1#n44

I am unsure about its support in Fuchsia, which is why I have not added
the constant there.
...in particular for 32-bit CPUs / ports, such as 32-bit arm,
i386, and powerpc.

In the C header files on NetBSD, this is defined as

  typedef unsigned long   cpuid_t;

and on ILP32 CPUs, that ends up being a 32-bit quantity.
Defining this as a 64-bit type wrecks havoc on our 32-bit ports
when e.g. _cpuset_isset() is used (as was introduced with 1.72.0),
causing immediate SEGV due to NULL pointer de-reference, as observed
in

  rust-lang/rust#116665

So, instead, define it as ::c_ulong, and let the CPU-specific type
definitions take care of the sizing.
ifreq for apple follow-up fix case when in non libc_union case
NetBSD's mod.rs: fix cpuid_t definition.

...in particular for 32-bit CPUs / ports, such as 32-bit arm, i386, and powerpc.

In the C header files on NetBSD, this is defined as

  typedef unsigned long   cpuid_t;

and on ILP32 CPUs, that ends up being a 32-bit quantity. Defining this as a 64-bit type wrecks havoc on our 32-bit ports when e.g. _cpuset_isset() is used (as was introduced with rust 1.72.0), causing immediate SEGV due to NULL pointer de-reference, as observed in

  rust-lang/rust#116665

So, instead, define it as ::c_ulong, and let the CPU-specific type definitions take care of the sizing.
ifconf addition to apple. fixing freebsd's implementation while at it.
adding exect/execvP for FreeBSD/DragonflyBSD
Add time namespace constant

This constant is a possible bitflag argument for `unshare`: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/include/uapi/linux/sched.h?h=v6.6-rc1#n44

I am unsure about its support in Fuchsia, which is why I have not added the constant there.
@github-actions github-actions bot added automation Issue or PR created by an automation backport:never PR that should never be backported labels Oct 16, 2023
Copy link
Member

@pietroalbini pietroalbini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@bors-ferrocene
Copy link
Contributor

Build succeeded:

  • full

@bors-ferrocene bors-ferrocene bot merged commit d15c1ec into main Oct 17, 2023
3 checks passed
@bors-ferrocene bors-ferrocene bot deleted the automation/pull-subtrees/pvnxiecl branch October 17, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation Issue or PR created by an automation backport:never PR that should never be backported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants