Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed typescript checker output errors live update #217

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

HonLuk
Copy link

@HonLuk HonLuk commented Feb 6, 2023

fixed overlay and terminal show error count not same as tsc message display errors count of typescript checker until all ts errors resovled.
image

@netlify
Copy link

netlify bot commented Feb 6, 2023

Deploy Preview for vite-plugin-checker ready!

Name Link
🔨 Latest commit 119df2f
🔍 Latest deploy log https://app.netlify.com/sites/vite-plugin-checker/deploys/63e0c56d82813c000a052f4d
😎 Deploy Preview https://deploy-preview-217--vite-plugin-checker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@fi3ework fi3ework force-pushed the main branch 4 times, most recently from abd4d48 to d6ef546 Compare June 19, 2023 18:48
@fi3ework
Copy link
Owner

fi3ework commented Jul 8, 2023

Sorry for the late response, could you provide a description of how to reproduce the issue the PR fixes?

@HonLuk
Copy link
Author

HonLuk commented Jul 26, 2023

Sorry for the late response, could you provide a description of how to reproduce the issue the PR fixes?

Its been a long time.
The problem of repair occurs in my project, and the probably manifested as:
I created two errors in the TypeScript code. I fixed one of them. Now there is only one left (as the terminals in the screenshot are displayed), but in the error prompt Dialog, I will not delete the error I have solved. Essence
After submitting PR before, I have been using patch-package to make my code take effect. It has been used for 5 months, and it works well.

@fi3ework
Copy link
Owner

Yeah, could you describe how to reproduce the duplicated error shown with minimal reproduction? If so, maybe we could check the root cause of this issue instead of prevent it from showing to userland.

@HonLuk
Copy link
Author

HonLuk commented Jul 27, 2023

Yeah, could you describe how to reproduce the duplicated error shown with minimal reproduction? If so, maybe we could check the root cause of this issue instead of prevent it from showing to userland.

It's not prevent it from showing to userland, but when the multiple errors has been resolved, dialog will keep the resolved errors in dialog,until all the errors have been fixed.

I can't reproduce the mistakes on my new machine may be related to computer performance.maybe ignore this PR.

The previous reproduction code:
step.1

const a = "";
a = 1; // first error
b = ""; // second error

dialog show two errors.

step.2
then dialog will show two errors.we fix first error:

const a = "";
b = ""; // second error still keep

then dialog will keep step 1 error in dialog,until all errors been resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants