feat: add PersonalDataAndDocumentsDetailed kyc schema #122
Conversation
cajubelt
changed the title
src/kyc.ts
Outdated
| DL = 'DL', | ||
| } | ||
|
|
||
| // need [string, ...string[]] types to get zod enums to compile |
There was a problem hiding this comment.
i would have preferred using IdentificationDocumentType[] for both of these, but zod errored out because it doesn't like if you create empty enums I guess. I welcome other ideas of getting this to work though
| IdentificationDocumentType, | ||
| ...IdentificationDocumentType[], | ||
| ] = [IdentificationDocumentType.IDC, IdentificationDocumentType.DL] | ||
| const documentsWithoutBack: [ |
There was a problem hiding this comment.
...and the award for most uses of the word "document" in a single expression goes to... 🤣
| }), | ||
| ) | ||
| .and( | ||
| z |
There was a problem hiding this comment.
i assume the linter did this due to the next line's length, but weird to have a line containing only z here
There was a problem hiding this comment.
tbh i hate this but yes it's the linter
There was a problem hiding this comment.
futzed around for a while trying to get the z some company on that line, to no avail
| identificationDocumentType: identificationDocumentTypeWithBackSchema, | ||
| identificationDocumentBack: z.string(), | ||
| }) | ||
| .or( |
There was a problem hiding this comment.
If this or is "selected" by the parser (by identificationDocumentBack being omitted from the object), does the type of identificationDocumentType described here (identificationDocumentTypeWithoutBackSchema) override the more general one set above?
There was a problem hiding this comment.
That is, if identificationDocumentBack is missing, does this setup cause Zod to enforce that identificationDocumentType be of type identificationDocumentTypeWithoutBackSchema?
There was a problem hiding this comment.
I think so, but to avoid having to reason about this I just dropped it. seems simpler.
src/kyc.ts
Outdated
| z.object({ | ||
| email: z.string().regex(EMAIL_REGEX), | ||
| identificationDocumentFront: z.string(), | ||
| identificationDocumentType: identificationDocumentTypeSchema, |
There was a problem hiding this comment.
Actually, is this line required, considering both of the options below specify a more narrowly typed version of the same field?
There was a problem hiding this comment.
yeah I'll just get rid of it
|
🎉 This PR is included in version 11.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
similar to #121 but includes more semantics in the zod schemas, in particular:
also more DRY with the existing kyc schema