Add support for new KYC schema #121
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jophish
reviewed
Feb 1, 2023
src/kyc.ts
Outdated
| } | ||
| export const kycSchemaSchema = z.nativeEnum(KycSchema, { | ||
| description: 'kycSchemaSchema', | ||
| }) | ||
|
|
||
| export enum KycDocumentType { |
There was a problem hiding this comment.
Please follow the naming convention used in the specification itself; this should be IdentificationDocumentType.
src/kyc.ts
Outdated
| phoneNumber: z.string(), | ||
| email: z.string(), | ||
| selfieDocument: z.string(), | ||
| identificationDocumentType: z.enum(['IDC', 'PAS', 'DL']), |
There was a problem hiding this comment.
Please reference the type created above rather than repeating the hardcoded string values here.
cajubelt
added a commit
that referenced
this pull request
Feb 3, 2023
similar to #121 but includes more semantics in the zod schemas, in particular: - when the back of the document is required - what the email should look like also more DRY with the existing kyc schema
|
superceded by #122 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to revised spec with the new KYC schema
PersonalDataAndDocumentsDetailed(https://github.com/fiatconnect/specification/blob/main/fiatconnect-api.md#9312-personaldataanddocumentsdetailed):