Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add download explanation to export action started language. #12738

Merged
merged 2 commits into from May 12, 2024

Conversation

cheesegrits
Copy link
Contributor

Description

We just started using the baked in Filament export on a live site, and immediately got confused users asking where their exported file is. Added an explanation in the "Export Started" language.

Visual changes

I tried, but the notification keeps disappearing before I can get a screenshot. Picture in your mind a notification with the new language in it. :)

Which does beg the question of whether this notification should be sticky, as it's longer than usual, and contains instructions on the next action the user will need to take. So perhaps it should stay until dismissed?

Functional changes

  • Code style has been fixed by running the composer cs command.
  • Changes have been tested to not break existing functionality.
  • Documentation is up-to-date.

@danharrin danharrin added the i18n label May 12, 2024
@danharrin danharrin added this to the v3 milestone May 12, 2024
@danharrin danharrin merged commit e30a8f7 into filamentphp:3.x May 12, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants