feat: Imprement jwt-auth header auth method #2961
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Continued from filebrowser#2474 Co-authored-by: Travis Johnson <travis@thisguy.codes>
5 tasks
o1egl
reviewed
Mar 7, 2024
Comment on lines
+33
to
+35
| a.init.Do(func() { | ||
| a.remoteKeySet = oidc.NewRemoteKeySet(context.Background(), a.CertsURL) | ||
| }) |
There was a problem hiding this comment.
I think it's better to do it in the constructor func
func NewJWTAuth(...){
...
}
Comment on lines
+42
to
+47
| // The Application Audience (AUD) tag for your application | ||
| config := &oidc.Config{ | ||
| ClientID: a.Aud, | ||
| } | ||
|
|
||
| verifier := oidc.NewVerifier(a.Iss, a.remoteKeySet, config) |
There was a problem hiding this comment.
Looks like a good candidate to be moved into the constructor
|
|
||
| accessJWT := r.Header.Get(a.Header) | ||
| if accessJWT == "" { | ||
| return nil, os.ErrPermission |
There was a problem hiding this comment.
It would be nice to log an error here
|
|
||
| token, err := verifier.Verify(r.Context(), accessJWT) | ||
| if err != nil { | ||
| return nil, os.ErrPermission |
| payload := map[string]any{} | ||
| err = token.Claims(&payload) | ||
| if err != nil { | ||
| return nil, os.ErrPermission |
|
|
||
| user, err := usr.Get(srv.Root, payload[a.UsernameClaim]) | ||
| if nerrors.Is(err, errors.ErrNotExist) { | ||
| return nil, os.ErrPermission |
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change is based on #2474. See original PR for detailed description.
To configure the filebrowser for Cloudflare Zero Trust, run the following command:
🚨 Before submitting your PR, please read community, and indicate which issues (in any of the repos) are either fixed or closed by this PR. See GitHub Help: Closing issues using keywords.
Further comments