Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: shell display related #3198

Merged
merged 3 commits into from May 19, 2024
Merged

fix: shell display related #3198

merged 3 commits into from May 19, 2024

Conversation

gdy666
Copy link
Contributor

@gdy666 gdy666 commented May 5, 2024

Fix shell div width display problem
Fixed the issue where shell__divider height is 0, resulting in the inability to drag and drop to change the height of the shell div.
Improve the problem of background color and font conflict making it difficult to see clearly

@gdy666 gdy666 requested a review from o1egl as a code owner May 5, 2024 14:38
@gdy666 gdy666 changed the title fix: shell.css fix shell display related May 5, 2024
@gdy666 gdy666 changed the title fix shell display related fix: shell display related May 5, 2024
@o1egl
Copy link
Member

o1egl commented May 11, 2024

This PR fixes the cli box sizing, but breaks the colors in the dark theme. Could you please fix that Screenshot 2024-05-11 at 22 29 07

@gdy666
Copy link
Contributor Author

gdy666 commented May 14, 2024

This PR fixes the cli box sizing, but breaks the colors in the dark theme. Could you please fix that Screenshot 2024-05-11 at 22 29 07

I tried to fix it

@kloon15
Copy link
Contributor

kloon15 commented May 16, 2024

This PR fixes the cli box sizing, but breaks the colors in the dark theme. Could you please fix that Screenshot 2024-05-11 at 22 29 07

I tried to fix it

Could you please create/use css-vars for the colors? So we dont have to have extra dark classes.

@o1egl o1egl merged commit 4c5b612 into filebrowser:master May 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants