Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed issue with password managers autofill #3207

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

coolchevy
Copy link

@coolchevy coolchevy commented May 7, 2024

Description

馃毃 Before submitting your PR, please indicate which issues are either fixed or closed by this PR. See GitHub Help: Closing issues using keywords.

  • DO make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
  • DO make sure you are making a pull request against the master branch (left side). Also you should start your branch off our master.
  • DO make sure that File Browser can be successfully built. See builds and development.
  • AVOID breaking the continuous integration build.

Further comments

Closing issues #2518 #2035

@coolchevy coolchevy requested a review from o1egl as a code owner May 7, 2024 19:37
@o1egl
Copy link
Member

o1egl commented May 11, 2024

Some people prefer to disable password manager support on certain fields, while others prefer to have it. The CSS solution provided is non-standard and may not be reliable. Personally, I use 1Password and have no issues with autofill. If there is an issue with a specific password management, we might consider adding some ignore data attributes

@coolchevy
Copy link
Author

@o1egl you need to test how Password Manger works now. It more looks like security issue for beginner PC users when this users input a password for sharing links using their personal password for file browser login.
I can't find an idea how is password manager could be used with sharing files, because if user will accept to save password - password manager will create new user/password for user login.
I'm tried to do it with autocomplete="off", but it is not working .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants