Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: curio: jsonrpc in webui #11904

Merged
merged 4 commits into from
May 24, 2024
Merged

feat: curio: jsonrpc in webui #11904

merged 4 commits into from
May 24, 2024

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Apr 19, 2024

Related Issues

On top of #11901

Proposed Changes

  • Implement basic jsonrpc client module
    • It was easier to ask chatgpt to write this than to convince any of the existing, massively overengineered modules to work in a browser without bundlers
  • Move chain-connectivity to RPC

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@magik6k magik6k requested a review from snadrus April 19, 2024 09:58
Base automatically changed from feat/ui-menu to master April 19, 2024 15:08
Copy link

github-actions bot commented May 24, 2024

Some checks haven't completed yet

@magik6k magik6k merged commit 9851d35 into master May 24, 2024
94 of 96 checks passed
@magik6k magik6k deleted the feat/curio-jsonrpc-ui branch May 24, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants