Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cli: lotus-miner sectors extend command #11928

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

beck-8
Copy link
Contributor

@beck-8 beck-8 commented Apr 25, 2024

Related Issues

#11927

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

Copy link
Contributor Author

@beck-8 beck-8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still incorrect.

@rjan90
Copy link
Contributor

rjan90 commented Apr 27, 2024

Thank you so much for the PR. I think this PR just needs a make gen (run the command while in your /lotus folder), to pass the final check.

@rjan90 rjan90 changed the title fix sectors extend fix: cli: lotus-miner sectors extend command Apr 27, 2024
@jennijuju jennijuju requested a review from magik6k May 28, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants