Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: curio: Drop FKs from pipeline to fix retry loops #11973

Merged
merged 1 commit into from
May 15, 2024

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented May 7, 2024

Related Issues

Much simpler approach to #11959

Proposed Changes

Not handled in poller yet, tho any handling strategy will likely be "just wait for user action" initially until we develop smarter repair logic.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

Copy link
Contributor

@LexLuthr LexLuthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@LexLuthr
Copy link
Contributor

LexLuthr commented May 9, 2024

This will basically leave all bad sectors in the pipeline table and poller won't touch them.
For the retry strategy, we can allow a manual UI retry for upto 72 hours(or less). After that, we should probably clean up and get back the storage resources.
We can generate an alert for such sectors to make it easier for users.

@magik6k magik6k merged commit e14a85b into master May 15, 2024
185 of 186 checks passed
@magik6k magik6k deleted the fix/curio-poller-nofk-retry branch May 15, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants