Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: merge release/v1.26.4 branch into the releases branch #11982

Closed
wants to merge 8 commits into from

Conversation

rjan90
Copy link
Contributor

@rjan90 rjan90 commented May 9, 2024

Proposed Changes

Lifting a couple of bugfixes into a patch release that was missed in the v1.26.x branches, as point out by Riba here.

Most notebly the ListClaimsCmd has been refined to correctly filter out expired claims, the SectorOnChainInfo in lotus/chain/actors/builtin/miner now correctly points to v13 GST. As well as smaller updates to error messages and parts missed in the release engineering process.

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

rvagg and others added 8 commits April 22, 2024 21:09
* deps: update dependencies to address migration memory bloat

to address memory concerns during a heavy migration

Ref: filecoin-project/go-state-types#260
Ref: whyrusleeping/cbor-gen#96
Ref: filecoin-project/go-amt-ipld#90

* release: prep v1.26.3 patch

Prep v1.26.3 patch release:
- Update changelog, version and make gen + make docsgen-cli

* deps: update cbor-gen to tagged version

deps: update cbor-gen to tagged version

* deps: update go-state-types to tagged version

deps: update go-state-types to tagged version v0.13.2

* chore: deps: update go-state-types to v0.13.3

Fixes a panic when we have fewer than 1k proposals.

---------

Co-authored-by: Phi <orjan.roren@gmail.com>
Co-authored-by: Steven Allen <steven@stebalien.com>
Bump pubsub-dep
Adjust ListClaimsCmd to filter out the expired claims. Ref: #11699 (comment)
Update error message
Add parts missed in releng. Most noteably pointing SectorOnChainInfo in lotus/chain/actors/builtin/miner to v13
Bump version, and changelog
@rjan90 rjan90 requested a review from a team as a code owner May 9, 2024 13:07
"ReplacedDayReward": "0",
"SectorKeyCID": {
"/": "bafy2bzacea3wsdh6y3a36tb3skempjoxqpuyompjbmfeyf34fi3uy6uue42v4"
},
"SimpleQAPower": true
"Flags": 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What change is causing this diff ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is because we have moved to miner13 types. lgtm.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make gen generated those after we changed to miner13 in 941d0be

Copy link
Contributor

@aarshkshah1992 aarshkshah1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question

@jennijuju
Copy link
Member

shouldnt this be merged before the next v1.27.x release?

@rjan90 rjan90 closed this May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants