feat: ETH TRACE API: Trace installed bytecode in the Ethereum JSON-RPC trace_block output #11984
Conversation
|
@Stebalien Does this look correct ? |
| if deployedCode != nil { | ||
| var getBytecodeReturn evm12.GetBytecodeReturn | ||
| if err := getBytecodeReturn.UnmarshalCBOR(bytes.NewReader(et.MsgRct.Return)); err == nil && getBytecodeReturn.Cid != nil { | ||
| deployedCode[abi.ActorID(id)] = getBytecodeReturn.Cid |
There was a problem hiding this comment.
@Stebalien This is not correct. How do I get the byte code of the contract here ?
There was a problem hiding this comment.
Do I need to make a call to the GetBytecode method of the contract Actor ?
Looks like none of the trace types we here have the byte code in them.
|
cc @eshon this PR should fix the issue you brought up in our 1:1! |
|
All checks have completed |
| var deployed map[abi.ActorID]*cid.Cid | ||
| if ir.MsgRct.ExitCode.IsSuccess() { | ||
| deployed = deployedCode | ||
| } |
There was a problem hiding this comment.
We need to do this per sub-trace. The top-level message can succeed while sub-messages cain fail.
Basically, move this into buildTraces and, if the receipt of the currently processed message has a non-zero exit code, set this to nil for the sub-call.
| for _, trace := range allTraces { | ||
| switch r := trace.Result.(type) { |
There was a problem hiding this comment.
This isn't correct, we want to update the last one only. The idea was to record a pointer to r.Code in deployedCode, so we could set it without even having to look at the traces. That is:
deployedCode := make(map[abi.ActorID]*EthBytes)Then, inside the buildTraces logic, we'd record deployedCode[receiverID] = &r.Code.
Finally, we'd iterate over deployedCode and set *deployedCode[receiverID] = loadByteCode(receiverID), as long as the receiver is still live.
Related Issues
Closes #11635.
Proposed Changes
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps