Feature: Added experimental terminal integration #13631
Conversation
|
I've added a setting under Experimental to enable/disable the feature (default: off). The feature may be good enough for first release :) |
yaira2
changed the title
|
I had some notes on this but I'll have another look since it's been a while. |
|
The main point to figure out before merging is whether the terminal is global, or if there can be a separate terminal for each tab & pane. I lean towards the second option (similar to VS Code). |
|
Holding off while @hez2010 checks if it's possible to use Windows Terminal control. |
|
Added ability to have more than one terminal 😇 |
|
Switching between terminals is working nicely! |
| Command="{x:Bind MainPageViewModel.TerminalAddCommand, Mode=OneWay}"> | ||
| <SplitButton.Content> | ||
| <TextBlock FontSize="12"> | ||
| <Run Text="Add" /> |
There was a problem hiding this comment.
| <Run Text="Add" /> | |
| <Run Text="{helpers:ResourceString Name=Add}" /> |
There was a problem hiding this comment.
Correction of text localization
| <SplitButton.Content> | ||
| <StackPanel Orientation="Horizontal" Spacing="8"> | ||
| <FontIcon FontSize="12" Glyph="" /> | ||
| <TextBlock Text="Terminal" /> |
There was a problem hiding this comment.
| <TextBlock Text="Terminal" /> | |
| <TextBlock | |
| Text="{helpers:ResourceString Name=Terminal}" | |
| ToolTipService.ToolTip="{helpers:ResourceString Name=ToggleShowTerminal}"/> |
There was a problem hiding this comment.
Correction of text localization and add tooltip
| @@ -3838,4 +3838,7 @@ | |||
| <data name="EditInNotepadDescription" xml:space="preserve"> | |||
| <value>Edit the selected file in Notepad</value> | |||
| </data> | |||
| <data name="SettingsTerminalIntegration" xml:space="preserve"> | |||
| <value>Enable Terminal integration</value> | |||
| </data> | |||
There was a problem hiding this comment.
| </data> | |
| </data> | |
| <data name="SyncFolderDown" xml:space="preserve"> | |
| <value>Down</value> | |
| </data> | |
| <data name="SyncFolderUp" xml:space="preserve"> | |
| <value>Up</value> | |
| </data> | |
| <data name="Terminal" xml:space="preserve"> | |
| <value>Terminal</value> | |
| </data> | |
| <data name="ToggleShowTerminal" xml:space="preserve"> | |
| <value>Toggle show Terminal</value> | |
| </data> |
Adding new keys
There was a problem hiding this comment.
But the name for SyncFolderDown --> Down? I don't know how to specify, maybe 'Return path' / 'Go back'
The same goes for SyncFolderUp --> Up? Maybe 'Use path' / 'Sync path' / 'Use this path'
But it will be localized
| Click="TerminalCloseButton_Click" | ||
| Tag="{x:Bind Id}" | ||
| ToolTipService.ToolTip="{helpers:ResourceString Name=Close}"> | ||
| <FontIcon FontSize="12" Glyph="" /> |
There was a problem hiding this comment.
| <FontIcon FontSize="12" Glyph="" /> | |
| <FontIcon FontSize="12" Glyph="" /> |
Use close symbol
| x:Load="{x:Bind MainPageViewModel.IsTerminalViewOpen, Mode=OneWay}" | ||
| Background="Transparent" | ||
| BorderBrush="Transparent" | ||
| Command="{x:Bind MainPageViewModel.TerminalSyncDownCommand}"> |
There was a problem hiding this comment.
| Command="{x:Bind MainPageViewModel.TerminalSyncDownCommand}"> | |
| Command="{x:Bind MainPageViewModel.TerminalSyncDownCommand}" | |
| ToolTipService.ToolTip="{helpers:ResourceString Name=SyncFolderDown}"> |
Add localized tooltip
| x:Load="{x:Bind MainPageViewModel.IsTerminalViewOpen, Mode=OneWay}" | ||
| Background="Transparent" | ||
| BorderBrush="Transparent" | ||
| Command="{x:Bind MainPageViewModel.TerminalSyncUpCommand}"> |
There was a problem hiding this comment.
| Command="{x:Bind MainPageViewModel.TerminalSyncUpCommand}"> | |
| Command="{x:Bind MainPageViewModel.TerminalSyncUpCommand}" | |
| ToolTipService.ToolTip="{helpers:ResourceString Name=SyncFolderUp}"> |
Add localized tooltip
Resolved / Related Issues
Closes Feature: Add terminal Integration #6235
Validation
How did you test these changes?
Screenshots (optional)
