Feature: Added transitions between pages #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaira2
changed the title
yaira2
previously approved these changes
Aug 30, 2023
yaira2
added
approved
Deploying with
|
| Latest commit: |
40f18e2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://47c438ea.files-website-cml.pages.dev |
| Branch Preview URL: | https://view-transitions.files-website-cml.pages.dev |
|
Was the blog page layout reversed? |
|
Yes, I discussed it with @mdtauk on discord and we agreed that it makes the transition look more natural. |
2 tasks
|
I think this is really cool, thanks for implementing this. Given that we now animate the page header when opening a blog page, would it be worth scrolling the top when opening a specific blog post? I know that the blog page being visible in the middle was present beforehand, however with the animation I feel like this oddity is made even worse. |
|
@chingucoding removing the Screencast.from.2023-09-03.21-34-48.mp4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added some cool new transitions between pages and among other elements, including:
Please comment if you have any ideas for what we can add; I'm so excited about this I'd love to just experiment and see what's possible.
Motivation and Context
SvelteKit recently added support for the
onNavigatelifecycle function, which unlocked the usage of the View Transition API.This API makes visually appealing, app-like transitions easily possible on the web, and I saw the opportunity and jumped on it.
Fixes #532
Screenshots (if appropriate):
Screencast.from.2023-08-29.23-13-16.mp4
Screencast_from_2023-08-29_22-38-31.mp4