Adding expansion.bzl for Improved Env Var Expansion
#28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CauhxMilloy
force-pushed
the
improvedExpansionWithBzl
branch
from
d2a4772
to
1909fab
Compare
* Adding `expansion.bzl` directly to this project. * Allows for better environment variable expansion than built-in skylark methods. * I'm also trying to submit this to Skylib (bazelbuild/bazel-skylib#486). * I could add this here (instead or in addition to). * Obviously, (also) adding this to Skylib would be more reusable for more repos. * Once submitted to Skylib (if accepted), this addition of `expansion.bzl` could be replaced with referencing the one in Skylib. * Doing this would add an extra dependency for bazel-bats (needing to pull in Skylib in `bazel_bats_dependencies()`). * Alternatively, could just keep this file here (for no extra dependency). * Updating `env` attribute expansion logic in `_bats_test_impl()`. * Allows better environment expansion logic than previously used. * Updating `tests/hello_world.bats` to validate many different environment variable expansion configurations. This is one approach for improving `bats_test` environment variable expansion logic (to get at least parity with built-in expansion logic). See https://github.com/CauhxMilloy/bazel-bats/tree/improvedExpansionWithShTest for `sh_test` approach.
CauhxMilloy
force-pushed
the
improvedExpansionWithBzl
branch
from
1909fab
to
1dde831
Compare
filmil
requested changes
Jan 31, 2024
…bzl`. * Switching `_odd_count_dollar_sign_repeat()` to `_even_count_dollar_sign_repeat()` and inverting logic at call sites. * Updating parameter name (`search_start` -> `search_start_index`) for more clarity.
|
Thanks for the quick review. Merge whenever you get the chance. (Please create a new tag, after the merge. Thanks!) |
filmil
approved these changes
Feb 3, 2024
CauhxMilloy
added a commit
to CauhxMilloy/bazel-skylib
that referenced
this pull request
Feb 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
expansion.bzldirectly to this project.expansion.bzlfor Fully Expanding Environment Variables bazelbuild/bazel-skylib#486).expansion.bzlcould be replaced with referencing the one in Skylib.bazel_bats_dependencies()).envattribute expansion logic in_bats_test_impl().tests/hello_world.batsto validate many different environment variable expansion configurations.This is one approach for improving
bats_testenvironment variable expansion logic (to get at least parity with built-in expansion logic). See https://github.com/CauhxMilloy/bazel-bats/tree/improvedExpansionWithShTest forsh_testapproach.Fixes #27.