Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: use FileSystem for globbing #418

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

WIP: use FileSystem for globbing #418

wants to merge 6 commits into from

Conversation

ajafff
Copy link
Member

@ajafff ajafff commented Sep 12, 2018 •
edited

Checklist

Overview of change

TODO:

  • add tests for new CachedFileSystem#isSymbolicLink
  • fine-tune MemoryFileSystem
    • make it work with symlinks linking to non-existent files
    • allow modifications and inspection of the final state
    • pass-through some real-existing folders and files (e.g. to resolve and require rules)
    • maybe replace with a combination of unionfs and memfs or memory-fs
  • move to separate package
    • rework GlobFileSystem API
    • add tests for different glob options, ideally use glob's test cases

@ajafff
Copy link
Member Author

ajafff commented Sep 13, 2018

Ref: isaacs/node-glob#280

@ajafff ajafff mentioned this pull request Jan 31, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make globbing use FileSystem abstraction
1 participant
@ajafff