Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CircleCI config #138

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Update CircleCI config #138

wants to merge 4 commits into from

Conversation

osanoj
Copy link
Contributor

@osanoj osanoj commented Dec 5, 2023

Why?

It was a little bit old.

What?

  • Use latest Xcode version.
  • See if we can use the M1 runner instead of Intel.

Version Change

No changes to the library

@osanoj osanoj requested review from a team, BjornRuud and teddyfahi and removed request for a team December 5, 2023 10:21
@osanoj
Copy link
Contributor Author

osanoj commented Dec 5, 2023

Screenshot 2023-12-05 at 11 24 51

"See if we can use the M1 runner instead of Intel." -> Nope

@@ -2,7 +2,8 @@ version: 2.1
jobs:
build-and-test:
macos:
xcode: 15.0.0
xcode: 15.0.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be specified less specific? Having to update for each patch version seems unnecessary. What about the resource_class, can that be more general?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was trying to check in their docs, but found no example of how to be less specific, but could of course just try to say 15 and see what happens 🤷

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works for Travis to use just 15 or 15.0, we should try same here...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works for Travis to use just 15 or 15.0, we should try same here...

They are two completely different services though..

Was trying to check in their docs, but found no example of how to be less specific, but could of course just try to say 15 and see what happens 🤷

They specify 15.0.0 in their docs https://circleci.com/docs/testing-ios/ but might just default to 15

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For sure

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately 15 didn't work so changing back to 15.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants