ELECTRON-978 (Implement native file picker modal window) #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VishwasShashidhar
suggested changes
Jan 2, 2019
js/preload/preloadMain.js
Outdated
| const browserWindow = remote.getCurrentWindow(); | ||
| const { type, title, defaultPath, multiSelect, filters } = options; | ||
| const properties = [ type ]; | ||
| if (multiSelect) properties.push('multiSelections'); |
There was a problem hiding this comment.
Please use braces around the if statement for consistency.
js/preload/preloadMain.js
Outdated
| const properties = [ type ]; | ||
| if (multiSelect) properties.push('multiSelections'); | ||
| remote.dialog.showOpenDialog(browserWindow, { title, defaultPath, properties, filters }, (filePaths) => { | ||
| if (!filePaths) return; |
There was a problem hiding this comment.
Please use braces around the if statement for consistency.
js/preload/preloadMain.js
Outdated
| const files = filePaths.map((file) => { | ||
| const mimeType = mime.lookup(file); | ||
| const filename = file.substring(file.lastIndexOf('/') + 1); | ||
| return new File([ fs.readFileSync(file) ], filename, { type: mimeType }); |
There was a problem hiding this comment.
If the file(s) is big & the system is slow, the UI thread will be blocked. Please use async version.
|
We don't need this work around anymore as the issue has been fixed on Electron framework electron/electron#16340 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Exposes an API to the web app to open a native file picker modal ELECTRON-978
Solution Approach
Expose an API which invokes
dialog.showOpenDialoginturnScreenshot
Related PRs
List related PRs against other branches / repositories:
QA Checklist