Improvements to the Rel transpiler #2699
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to Rel, better logging, and refactoring.
…ient generated Rel, a new implementation of schema construction via PURE model traversal, improved test coverage, bug fixes, and improved logging and debugging.
relationalai-opensource
requested review from
pierredebelen,
epsstan,
davidharte-gs,
gs-ssh16,
rafaelbey and
aormerod-gs
as code owners
pierredebelen
approved these changes
Apr 5, 2024
|
This PR can be closed because it is superseded by PR#2702 which has now been merged. |
|
This PR can be closed because it is superseded by #2702. Apologies for the noise. |
|
This PR is stale because it has been open for 30 days with no activity. Please remove stale label or add any comment to keep this open. Otherwise this will be closed in 5 days. |
|
This PR was closed because it has been inactive for 35 days. Please re-open if this PR is still relevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various improvements to the Rel transpiler:
restrictoperator, ensuring that arestrictfollowingjoinorprojectdoes not materialize unnecessary columns in intermediate relations in the transpiled Rel query.match.groupby.isEmpty().This PR builds on the work of #2622, and therefore that PR must be merged first.
What type of PR is this?
Improvement
What does this PR do / why is it needed ?
Support for more types of query by the Rel backend. This PR also improves the logging of errors when a Pure query is not supported by the Rel transpiler.
Does this PR introduce a user-facing change?
This PR is backwards compatible in the sense that existing queries will continue to be supported without any changes.
Some function names related to schema creation have changed. See test cases for examples.