Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable CORS requests for REPLGridServer #2832

Closed
wants to merge 1 commit into from
Closed

Enable CORS requests for REPLGridServer #2832

wants to merge 1 commit into from

Conversation

gayathrir11
Copy link
Contributor

What type of PR is this?

What does this PR do / why is it needed ?

Which issue(s) this PR fixes:

Fixes #

Other notes for reviewers:

Does this PR introduce a user-facing change?

@gayathrir11 gayathrir11 requested a review from a team as a code owner May 7, 2024 10:05
@github-actions GitHub Actions
Copy link

github-actions bot commented May 7, 2024

Test Results

     763 files  ±0       763 suites  ±0   1h 6m 34s ⏱️ -5s
12 597 tests ±0  12 364 ✔️ ±0  233 💤 ±0  0 ❌ ±0 
15 708 runs  ±0  15 457 ✔️ ±0  251 💤 ±0  0 ❌ ±0 

Results for commit ab2cdc1. ± Comparison against base commit a0f7fb0.

akphi
akphi requested changes May 7, 2024
View reviewed changes
Copy link
Contributor

@akphi akphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try using Filter rather than having to call enableCors for every end points

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akphi akphi akphi requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gayathrir11 @akphi