Fuzzy Matching Functions - Jaro Winkler Similarity and Levenshtein Distance #2839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhishoya-gs
changed the title
gs-ssh16
requested changes
May 16, 2024
...nPlan-dependencies/src/main/java/org/finos/legend/engine/plan/dependencies/util/Library.java
Outdated
Show resolved
Hide resolved
...gine-pure-code-compiled-core/src/main/resources/core/pure/router/routing/router_routing.pure
Show resolved
Hide resolved
...rces/core_java_platform_binding/legendJavaPlatformBinding/planConventions/stringLibrary.pure
Outdated
Show resolved
Hide resolved
...main/resources/core_relational_snowflake/relational/sqlQueryToString/snowflakeExtension.pure
Outdated
Show resolved
Hide resolved
...in/resources/core_relational/relational/sqlQueryToString/testSuite/dynaFunctions/string.pure
Outdated
Show resolved
Hide resolved
gs-ssh16
reviewed
May 23, 2024
| fc2(hash_String_1__HashType_1__String_1_, {ctx,text,hashType | $library->j_invoke('hash', [$text, $hashType], javaString())}) | ||
|
|
||
| fc2(hash_String_1__HashType_1__String_1_, {ctx,text,hashType | $library->j_invoke('hash', [$text, $hashType], javaString())}), | ||
| fc2(jaroWinklerSimilarity_String_1__String_1__Float_1_, {ctx,str1,str2 | $library->j_invoke('jaroWinklerSimilarity',[$str1, $str2], javaFloat())}), |
There was a problem hiding this comment.
Isn't return type javaDouble? As the Library method is this -
public static double jaroWinklerSimilarity(String str1, String str2)
gs-ssh16
reviewed
May 23, 2024
| @@ -42,6 +42,7 @@ function <<access.private>> meta::relational::functions::sqlQueryToString::duckD | |||
| { | |||
| let allStates = allGenerationStates(); | |||
| [ | |||
| dynaFnToSql('jaroWinklerSimilarity', $allStates, ^ToSql(format='JARO_WINKLER_SIMILARITY(%s, %s)')) | |||
gs-ssh16
reviewed
May 23, 2024
| @@ -158,9 +158,11 @@ function <<access.private>> meta::relational::functions::sqlQueryToString::snowf | |||
| dynaFnToSql('hour', $allStates, ^ToSql(format='date_part(\'hour\', %s)')), | |||
| dynaFnToSql('indexOf', $allStates, ^ToSql(format='CHARINDEX(%s)', transform={p:String[2] | $p->at(1) + ', ' + $p->at(0)})), | |||
| dynaFnToSql('isAlphaNumeric', $allStates, ^ToSql(format=regexpPattern('%s'), transform={p:String[1]|$p->transformAlphaNumericParamsDefault()})), | |||
| dynaFnToSql('jaroWinklerSimilarity', $allStates, ^ToSql(format='ROUND(JAROWINKLER_SIMILARITY(%s, %s)/100, 2)')), | |||
There was a problem hiding this comment.
Why round(x, 2)? Anyways it will be two digits only as does number b/n 0-100/100. Also, should we keep these in lowercase like most other functions
There was a problem hiding this comment.
Added for precision to output. But we can work without it as well, removed. Yes, lowercase would be more semantic, done.
gs-ssh16
reviewed
May 23, 2024
| { | ||
| if (string1 == ValueNull.INSTANCE || string2 == ValueNull.INSTANCE) | ||
| { | ||
| throw new IllegalArgumentException("Null values not supported in legend_h2_extension_edit_distance"); |
There was a problem hiding this comment.
Should return null rather than failing. Same goes for other method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Improvement
What does this PR do / why is it needed ?
Support for Jaro Winkler Similarity and Levenshtein Distance in Snowflake and DuckDb Runtime
Which issue(s) this PR fixes:
Fixes #
Other notes for reviewers:
Depends on finos/legend-pure#805
Does this PR introduce a user-facing change?
Yes, new functions