Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Modularization (last mile) #65

Open
16 of 20 tasks
akphi opened this issue Mar 7, 2021 · 0 comments
Open
16 of 20 tasks

RFC: Modularization (last mile) #65

akphi opened this issue Mar 7, 2021 · 0 comments
Labels
Studio Core Team Opened by a member of the Studio core team Type: Discussion Type: Enhancement Type: Maintenance DevOps, maintenance, admin works to do with the repository Type: Refactor
Milestone

Comments

@akphi
Copy link
Contributor

akphi commented Mar 7, 2021

Legend Studio core can still be broken down further; right now it still contains DSL-specifics and has the graph models, engine, and components all packed together. Following is a list of todos:

  • Remove or move-out everything in legend-studio/src/utils (Refactor #410)
    • Move Logger to shared, keep CORE_LOG_EVENT in core
    • Eliminate usage of SourceInformation in TextEditorUtil
    • Move TextEditorUtil to legend-studio-components
    • Move logic inside of MappingResolutionUtil to stores or metamodels accordingly
  • After elimitating legend-studio/src/utils/, break down legend-studio/src/models` into: (re-organization #422)
    • legend-server-sdlc
    • legend-server-depot
    • legend-graph
  • Modularize legend-extension-dsl-diagram: this is currently complicated by the fact that we're using DiagramRenderer (which consumes Diagram) in ClassEditor (Upgrade to Typescript 4.4 #439)
  • Feature request: Introduce extension mechanism consistently and exhaustively for class mapping #687
  • Modularize PlanViewer - Feature request: Modularize plan viewer #717
  • IMP Modularize AbstractPureGraphManager - publish doc website and improve Legend Studio analytics reporting #1266
  • Modularize flat-data: legend-extension-store-flat-data - flat-data might get removed in the near future - if we finish RFC: Support for the unsupported #315 - maybe we could just remove all flat-data logic
  • Modularize relational: legend-extension-store-relational
  • After relational, move external format out of core potentially?
  • Modularize service: legend-extension-dsl-service: We need to modularize how we start Legend Query
  • Modularize generation: legend-extension-dsl-generation - This is considered part of core so we will likely not need to modularize it until much needed
  • Modularize external-format: legend-extension-external-format (SchemaSet, Binding, etc.) - This will be motted as we really consider external format logic to be part of core, this will be consistent with engine
  • Modularize mapping: legend-extension-dsl-mapping - be careful and really consider if we need to do this. This will break Studio down to a really really simple core though, which is a plus - This will be omitted as it's not really necessary and could cost us a lot to do, even https://github.com/finos/legend-engine is not doing this.

... and the last mile is often never easy to cross, but at least one does have it in their sight.

@akphi akphi self-assigned this Mar 7, 2021
@akphi akphi removed their assignment Mar 25, 2021
@akphi akphi changed the title RFC: modularization RFC: Modularization (last mile) May 4, 2021
@akphi akphi pinned this issue May 4, 2021
@akphi akphi unpinned this issue Jun 22, 2021
@akphi akphi pinned this issue Jun 28, 2021
This was referenced Aug 17, 2021
This was referenced Aug 30, 2021
@akphi akphi added Studio Core Team Opened by a member of the Studio core team Type: Enhancement Type: Maintenance DevOps, maintenance, admin works to do with the repository labels Oct 29, 2021
@akphi akphi unpinned this issue Nov 16, 2021
@akphi akphi added this to the Marathon milestone Nov 16, 2021
@akphi akphi modified the milestones: Marathon, On Deck Jun 25, 2022
@akphi akphi added help wanted and removed good first issue Good for newcomers labels Nov 1, 2022
@akphi akphi removed the help wanted label Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Studio Core Team Opened by a member of the Studio core team Type: Discussion Type: Enhancement Type: Maintenance DevOps, maintenance, admin works to do with the repository Type: Refactor
Projects
None yet
Development

No branches or pull requests

1 participant