Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-organization #422

Merged
merged 49 commits into from Aug 20, 2021
Merged

re-organization #422

merged 49 commits into from Aug 20, 2021

Conversation

akphi
Copy link
Contributor

@akphi akphi commented Aug 18, 2021

Refactor

  • Rename @finos/legend-studio-plugin-tracer-zipkin -> @finos/legend-tracer-plugin-zipkin
  • Rename @finos/legend-studio-preset-external-format-json-schema -> @finos/legend-graph-preset-external-format-json-schema
  • Rename @finos/legend-studio-dev-utils -> @finos/legend-dev-utils
  • Rename @finos/legend-studio-shared -> @finos/legend-shared
  • Rename @finos/legend-studio-components -> @finos/legend-application-components

Rework release process

  • Add the following packages to separate deployment and app release:
    • @finos/legend-studio-app: holding the app core code that ties the set of plugins together
    • @finos/legend-studio-deployment: has Webpack, private: true
    • @finos/legend-query-app: holding the app core code that ties the set of plugins together
    • @finos/legend-query-deployment: has Webpack, private: true
  • Make changeset link @finos/legend-studio-app and @finos/legend-query-app to ensure they are of the same version - i.e. the version of Legend applications.
  • Document about this new process in docs/release-guide.md and create an empty root CHANGELOG.md

Modularization (#65)

  • Move SDLC code to @finos/legend-server-sdlc
  • Move metadata code to @finos/legend-server-depot
  • Move metamodels/graph/graph-manager/protocols to @finos/legend-graph

Cleanups

  • Cleanup rendering logics out of SDLC models
  • Move selectOption out of models

Bug fixes

Fixes #425
Fixes #426

Improvements

  • Move store provider and React hooks (e.g. EditorStoreProvider, useEditorStore, etc.) out of /stores and into /components. Hopefully this will help react-refresh in some way as editing *.tsx sometimes cause react-refresh to fail. We still observe fast-refresh failure when making modification in files like EditorStore and ApplicationStore but hopefully these kinds of things will be alleviated with this change. Also this change makes sense in code-perspective, hooks and providers are React concepts and should therefore be in /components instead of /stores

Misc


Started some of the work in #370

@changeset-bot
Copy link

changeset-bot bot commented Aug 18, 2021

🦋 Changeset detected

Latest commit: f86124f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 21 packages
Name Type
@finos/babel-preset-legend-studio Patch
@finos/eslint-plugin-legend-studio Patch
@finos/legend-application-components Patch
@finos/legend-dev-utils Patch
@finos/legend-graph Patch
@finos/legend-graph-preset-external-format-json-schema Patch
@finos/legend-model-storage Patch
@finos/legend-query-app Patch
@finos/legend-query-deployment Patch
@finos/legend-server-depot Patch
@finos/legend-server-sdlc Patch
@finos/legend-shared Patch
@finos/legend-studio Patch
@finos/legend-studio-app Patch
@finos/legend-studio-deployment Patch
@finos/legend-studio-manual-tests Patch
@finos/legend-studio-plugin-management Patch
@finos/legend-studio-preset-dsl-text Patch
@finos/legend-studio-preset-query-builder Patch
@finos/legend-tracer-plugin-zipkin Patch
@finos/stylelint-config-legend-studio Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@finos-cla-bot finos-cla-bot bot added the cla-present CLA Signed label Aug 18, 2021
@codecov
Copy link

codecov bot commented Aug 18, 2021

Codecov Report

Merging #422 (f86124f) into master (b83c255) will decrease coverage by 15.11%.
The diff coverage is 16.95%.

@@             Coverage Diff             @@
##           master     #422       +/-   ##
===========================================
- Coverage   45.38%   30.27%   -15.12%     
===========================================
  Files         762      778       +16     
  Lines       36170    36157       -13     
  Branches     8395     8404        +9     
===========================================
- Hits        16417    10945     -5472     
- Misses      19692    25158     +5466     
+ Partials       61       54        -7     
Impacted Files Coverage Δ
packages/babel-preset/index.js 0.00% <0.00%> (ø)
...on-components/src/components/BaseMuiComponents.tsx 0.00% <ø> (ø)
...mponents/src/components/ComponentsConfiguration.ts 14.28% <ø> (ø)
...-components/src/components/CustomSelectorInput.tsx 13.51% <ø> (ø)
...plication-components/src/components/LegendLogo.tsx 0.00% <ø> (ø)
...onents/src/components/dialog/NonBlockingDialog.tsx 16.66% <ø> (ø)
...ion-components/src/components/menu/ContextMenu.tsx 12.76% <ø> (ø)
...on-components/src/components/menu/DropdownMenu.tsx 30.43% <ø> (ø)
...ion-components/src/components/menu/MenuContent.tsx 0.00% <ø> (ø)
...ponents/src/components/panel/BlankPanelContent.tsx 0.00% <ø> (ø)
... and 1228 more

@akphi akphi mentioned this pull request Aug 19, 2021
17 tasks
@akphi akphi mentioned this pull request Aug 20, 2021
20 tasks
@akphi akphi marked this pull request as ready for review August 20, 2021 23:06
@akphi akphi merged commit 985eef5 into finos:master Aug 20, 2021
@akphi akphi deleted the gauguin branch August 20, 2021 23:29
@github-actions github-actions bot mentioned this pull request Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-present CLA Signed
Projects
None yet
2 participants