Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build performance improvements #924

Merged
merged 6 commits into from Mar 8, 2022
Merged

build performance improvements #924

merged 6 commits into from Mar 8, 2022

Conversation

akphi
Copy link
Contributor

@akphi akphi commented Mar 8, 2022

Summary

  • Fix a regression with view project button launches a link without the base URL
  • Add package manifest check script
  • Move away from using yarn workspaces foreach for build script temporarily to improve build performance - see [Feature] Improve performance of yarn run yarnpkg/berry#2575
    • Now parallel to the tsconfig.json project reference tree, we have tsconfig.build.json project reference tree, which will be used by tsc for yarn build

How did you test this change?

  • Test(s) added
  • Manual testing (please provide screenshots/recordings)
  • No testing (please provide an explanation)

@changeset-bot
Copy link

changeset-bot bot commented Mar 8, 2022

🦋 Changeset detected

Latest commit: 2921dc7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 29 packages
Name Type
@finos/legend-application Patch
@finos/legend-art Patch
@finos/legend-dev-utils Patch
@finos/legend-extension-dsl-data-space Patch
@finos/legend-extension-dsl-diagram Patch
@finos/legend-extension-dsl-serializer Patch
@finos/legend-extension-dsl-text Patch
@finos/legend-extension-external-format-json-schema Patch
@finos/legend-extension-external-language-morphir Patch
@finos/legend-extension-external-store-service Patch
@finos/legend-graph Patch
@finos/legend-graph-extension-collection Patch
@finos/legend-model-storage Patch
@finos/legend-query Patch
@finos/legend-query-app Patch
@finos/legend-server-depot Patch
@finos/legend-server-sdlc Patch
@finos/legend-shared Patch
@finos/legend-studio Patch
@finos/legend-studio-app Patch
@finos/legend-studio-extension-management-toolkit Patch
@finos/legend-studio-extension-query-builder Patch
@finos/legend-taxonomy Patch
@finos/legend-taxonomy-app Patch
@finos/legend-tracer-extension-zipkin Patch
@finos/legend-manual-tests Patch
@finos/legend-query-deployment Patch
@finos/legend-studio-deployment Patch
@finos/legend-taxonomy-deployment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@finos-cla-bot finos-cla-bot bot added the cla-present CLA Signed label Mar 8, 2022
@codecov
Copy link

codecov bot commented Mar 8, 2022

Codecov Report

Merging #924 (2921dc7) into master (244c7f1) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #924      +/-   ##
==========================================
- Coverage   42.73%   42.72%   -0.01%     
==========================================
  Files         958      958              
  Lines       43799    43806       +7     
  Branches    10210    10216       +6     
==========================================
+ Hits        18716    18717       +1     
- Misses      25009    25015       +6     
  Partials       74       74              
Impacted Files Coverage Δ
.../legend-dev-utils/ProjectReferenceConfigChecker.js 0.00% <0.00%> (ø)
...ery/src/components/QueryBuilderPostFilterPanel.tsx 12.54% <0.00%> (ø)
...nd-studio/src/components/setup/ProjectSelector.tsx 70.27% <ø> (ø)
.../components/QueryBuilderFunctionsExplorerPanel.tsx 11.03% <0.00%> (ø)
...ckages/legend-query/src/stores/LegendQueryStore.ts 19.42% <0.00%> (+0.29%) ⬆️

@akphi akphi merged commit 4e25827 into finos:master Mar 8, 2022
@akphi akphi deleted the jump branch March 8, 2022 22:19
@github-actions github-actions bot mentioned this pull request Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-present CLA Signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants