Skip to content

Commit

Permalink
Override MimePull lib version being pulled by SpringBoot to avoid err…
Browse files Browse the repository at this point in the history
…or when running on Java8
  • Loading branch information
pankajpkhandelwal-db committed Jul 5, 2022
1 parent 9db4811 commit 540cc2a
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 3 deletions.
2 changes: 1 addition & 1 deletion demos/demo-bot/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<groupId>org.finos.springbot</groupId>
<artifactId>spring-bot</artifactId>
<version>9.0.1-SNAPSHOT</version>
<relativePath>../..</relativePath>
<relativePath>../../pom.xml</relativePath>
</parent>

<groupId>org.finos.springbot.demos</groupId>
Expand Down
2 changes: 1 addition & 1 deletion demos/rooms-bot/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<groupId>org.finos.springbot</groupId>
<artifactId>spring-bot</artifactId>
<version>9.0.1-SNAPSHOT</version>
<relativePath>../..</relativePath>
<relativePath>../../pom.xml</relativePath>
</parent>

<groupId>org.finos.springbot.demos</groupId>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ public TeamsStateStorage teamsAzureBlobStateStorage(
@Bean
@ConditionalOnProperty(matchIfMissing = true, name = "teams.storage.type", havingValue = "memory")
@ConditionalOnMissingBean
public TeamsStateStorage teamsAzureBlobStateStorage() {
public TeamsStateStorage teamsInMemoryStateStorage() {
LOG.warn("Using Memory storage for Azure data - NOT FOR PRODUCTION");
return new MemoryStateStorage();
}
Expand Down
8 changes: 8 additions & 0 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@
<jsoup.version>1.14.3</jsoup.version>
<graalvm.version>21.2.0</graalvm.version>
<symphony-bdk.version>2.5.0</symphony-bdk.version>
<mimepull.version>1.9.15</mimepull.version>
</properties>

<licenses>
Expand Down Expand Up @@ -211,6 +212,13 @@

<dependencyManagement>
<dependencies>
<!-- SpringBoot 2.7.0 pulls 1.10 version of below lib which is compiled with Java11 and hence causes errors -->
<dependency>
<groupId>org.jvnet.mimepull</groupId>
<artifactId>mimepull</artifactId>
<version>${mimepull.version}</version>
</dependency>

<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-core</artifactId>
Expand Down

0 comments on commit 540cc2a

Please sign in to comment.