Override MimePull lib version #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or when running on Java8
vaibhav-db
approved these changes
Jul 5, 2022
|
What's mime pull used for? Is the version you're proposing compatible with Spring Boot 2.7? |
|
Jersey-media-multipart has dependency on mimepull lib. However, newer version of dependency is forced via SpringBoot 2.7.0 BOM. See this link for issue details - spring-projects/spring-boot#31133 This explain why they added it in 1st place - spring-projects/spring-boot#14924 Instead of removing dependency altogether, its safe to downgrade it to latest version compiled with Java8. Ran Bot post changes on both Symphony and MS Teams and they ran fine. |
robmoffat
approved these changes
Jul 12, 2022
...orkflow-spring-boot-starter/src/main/java/org/finos/springbot/teams/TeamsWorkflowConfig.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SpringBoot 2.7.0 pulls 1.10 version of below lib which is compiled with Java11 and hence causes errors when running on Java8