1073 support different locales and timezones #1091
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for papaya-valkyrie-395400 canceled.
|
junaidzm13
force-pushed
the
1073-support-different-locales-and-timezones
branch
7 times, most recently
from
2727b7d
to
1f7a584
Compare
junaidzm13
force-pushed
the
1073-support-different-locales-and-timezones
branch
from
1f7a584
to
55b7e7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR builds on top of #1087 by adding functionality to allow users to choose date/time locale and timezone.
Users can specify locale/timezone on a table level (open to suggestions if we'd like to have these on app/column level, I just think its hard/odd to think of a usecase where users would want to have different locales/timezones for different columns within the same table). Having it on table level in my view, provides just enough flexibility.
In case the users do not specify locale/timezone, it fallsback to the user's defaults (for instance in the screenshot below, it falls back to en-GB/HongKong for me).
For now I've only added a few options (other than the user's defaults) for locale/timezone in the dropdowns. We can always add more or just stick with a few most used. Open to suggestions.