Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(delete-user-data): storage bucket param #532

Merged
merged 1 commit into from
Jan 13, 2021

Conversation

russellwheatley
Copy link
Member

fixes #531

Here is a log of the {DEFAULT}/testext/{UID}.jpg being deleted:
Screenshot 2020-12-14 at 15 42 53

I also spent some time trying to run the emulator for this extension. The cloud function emulator ran as expected, the auth emulator did not. I'll create an issue on the firestore-tools repository.

@google-cla google-cla bot added the cla: yes Author has signed the CLA label Dec 14, 2020
@russellwheatley russellwheatley marked this pull request as ready for review December 14, 2020 16:33
@russellwheatley
Copy link
Member Author

I've created three separate issues for the extension emulators:
firebase/firebase-tools#2928
firebase/firebase-tools#2929
firebase/firebase-tools#2930

@jhuleatt jhuleatt merged commit 8ae9f4e into next Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Author has signed the CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

delete-user-data doesn't recognize {DEFAULT} Storage bucket
4 participants